-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: BrowserView drag now delegates to the OS when possible #31114
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
cc @codebytere ; here is the PR for #31058 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey great find!
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
I have automatically backported this PR to "13-x-y", please check out #31175 |
I have automatically backported this PR to "14-x-y", please check out #31176 |
I have automatically backported this PR to "15-x-y", please check out #31177 |
I have automatically backported this PR to "16-x-y", please check out #31178 |
Description of Change
This PR fixes issue #31058, inconsistent window dragging behavior between
BrowserWindow
s andBrowserView
s. The root cause was a malformed selector, which noview.window
instances could respond to.https://www.loom.com/share/3ab47d45a0be4223af88b3377a800cd9
[Guidance appreciated for the Checklist and Release Notes sections. This change should help Electron better implement its current documentation; no new docs or userland education is expected.
npm test
is failing for me on node-gyp rebuilds, so hoping CI can confirm this is safe.]Checklist
npm test
passesRelease Notes
Notes: Fixes an issue where BrowserView dragging behavior was inconsistent with MacOS window dragging.